Simple JavaScript Calculator with JQuery -


i've been working on simple javascript calculator more few days. css , html seem good. calculator works sevens , division function! other numbers show in top output line expected, lower output outputs answer sevens , division. can't seem figure out why jquery isn't inputting on click. appreciated! link codepen... http://codepen.io/rdaniels34/pen/mkxokx

/*******************************    math functions *******************************/  var topnumber = []; var newnumber = []; var operator = []; var computednumber = [];  /**********************************     mathematical function buttons  ***********************************/  function clrfunction() {   topnumber.splice(0, topnumber.length);   document.getelementbyid("numberdisplay1").innerhtml = 0;   computednumber.splice(0, computednumber.length);   document.getelementbyid("numberdisplay2").innerhtml = 0; }  function dividefunction() {   topnumber[topnumber.length] = " / ";   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function timesfunction() {   topnumber[topnumber.length] = " x ";   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function backspacefunction() {   topnumber.splice(topnumber.length - 1, 1);   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join("");   if (topnumber.length == []) {     document.getelementbyid("numberdisplay1").innerhtml = 0;   } }  function subtractfunction() {   topnumber[topnumber.length] = " - ";   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function addfunction() {   topnumber[topnumber.length] = " + ";   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function percentfunction() {   topnumber[topnumber.length] = "% ";   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function rd34function() {   document.getelementbyid("numberdisplay1").innerhtml = "programming fun!"; }  //function plusminusfunction() { //  var newnumber = ""; //  if (topnumber < 0) { //    newnumber = +(topnumber); //  } else if (topnumber > 0) { //    newnumber = -(topnumber); //  } //  return plusminusfunction();  // document.getelementbyid("numberdisplay1").innerhtml = topnumber.splice(0, 0, newnumber); // }  function decimalfunction() {   topnumber[topnumber.length] = ".";   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  //function equalsfunction() { //  document.getelementbyid("numberdisplay1").innerhtml = topnumber.join("").eval(topnumber); //      if (topnumber.length == []) { //        document.getelementbyid("numberdisplay2").innerhtml = 0; //      } //}  /****************************     number button functions  *****************************/  function onefunction() {   topnumber[topnumber.length] = 1;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function twofunction() {   topnumber[topnumber.length] = 2;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function threefunction() {   topnumber[topnumber.length] = 3;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function fourfunction() {   topnumber[topnumber.length] = 4;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function fivefunction() {   topnumber[topnumber.length] = 5;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function sixfunction() {   topnumber[topnumber.length] = 6;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function sevenfunction() {   topnumber[topnumber.length] = 7;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function eightfunction() {   topnumber[topnumber.length] = 8;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function ninefunction() {   topnumber[topnumber.length] = 9;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }  function zerofunction() {   topnumber[topnumber.length] = 0;   document.getelementbyid("numberdisplay1").innerhtml = topnumber.join(""); }     /*********************************        bottom number display     ********************************/   $(document).ready(function() {    var testnumlength = function(firstnumber) {     if (firstnumber.length > 9) {       $("#numberdisplay2").text(firstnumber.substr(firstnumber.length - 9, 9));       if (firstnumber.length > 15) {         firstnumber = "";         $("#numberdisplay2").text("err");       }     }   };    var firstnumber = "";   var secondnumber = "";   var answer = "";   var operator = "";   $("#numberdisplay2").text("0");    $("#numbers").click(function() {     firstnumber += $(this).text();     $("#numberdisplay2").text(firstnumber);     testnumlength(firstnumber);   });    $("#operator").click(function() {     operator = $(this).text();     secondnumber = firstnumber;     firstnumber = "";     $("#numberdisplay2").text();   });     $("#clr").click(function() {      firstnumber = "";      $("#numberdisplay2").text("0");      if ($(this).attr("id") == "clr") {        firstnumber = "";      }    });    $("#backspace").click(function () {     firstnumber -= $(this).text();     $("#numberdisplay2").text(firstnumber);     testnumlength(firstnumber);    });    $("#equals").click(function() {     var answer = "";      parsefloat(firstnumber);     parsefloat(secondnumber);       if (operator == "-") {       answer = secondnumber - firstnumber;     } else if (operator == "x") {       answer = secondnumber * firstnumber;     } else if (operator == "/") {       answer = secondnumber / firstnumber;     } else if (operator == "+") {       answer = secondnumber + firstnumber;     }      //  else if (operator == "%") {     //    solution = number / 100;     //  }      //answer.tostring("");     $("#numberdisplay2").text(answer.tofixed(6));     testnumlength(answer);     //newnumber = "";     //nextnumber = "";   }); });

the issue have used same html identifier multiple times numbers. 

 <button type="button" onclick="ninefunction()" id="numbers" class="btn btn-default btn-sm">9</button>  <button type="button" onclick="fourfunction()" id="numbers" class="btn btn-default btn-sm">4</button>  <button type="button" onclick="fivefunction()" id="numbers" class="btn btn-default btn-sm">5</button>

so when browser interprets code:

  $("#numbers").click(function() {     firstnumber += $(this).text();     $("#numberdisplay2").text(firstnumber);     testnumlength(firstnumber);   });

it not understand numbers element intending reference.

to fix this, need either use class .numbers or give each number button it's own unique html id , bind that.

as example:

 <button type="button" onclick="ninefunction()" class="numbers btn btn-default btn-sm">9</button>  <button type="button" onclick="fourfunction()" class="numbers btn btn-default btn-sm">4</button>

and change code to:

$(".numbers").click(function() {     firstnumber += $(this).text();     $("#numberdisplay2").text(firstnumber);     testnumlength(firstnumber); });

Comments

Post a Comment

Popular posts from this blog

java - pagination of xlsx file to XSSFworkbook using apache POI -

right in code, reading xlsx file, xssfworkbook, , writing database. but, when size of xlsx file increases, causes outofmemory error. can not increase server size, or divide xlsx file pieces. tried loading workbook using file (instead of inputstream), didn't either. i looking way read 10k rows @ time (instead of entire file @ once) , iteratively write workbook , database. is there way apache poi? poi contains called "eventmodel" designed purpose. it's mentioned in faq : the ss eventmodel package api reading excel files without loading whole spreadsheet memory. require more knowledge on part of user, reduces memory consumption more tenfold. based on awt event model in combination sax. if need read-only access, best way it. however, may want double check first if issue somewhere else. check out this item : i think poi using memory! can do? 1 comes quite lot, reason isn't might think. so, first thing check - what's source of prob...
Read more

Unlimited choices in BASH case statement -

consider simple bash snippet: case $option in 1) image=${options[0]%.tar} ;; 2) image=${options[1]%.tar} ;; 3) image=${options[2]%.tar} ;; 4) image=${options[3]%.tar} ;; *) echo "invalid option" exit 1 esac in real script numbers goes 30. makes pretty long. can somehow specify cases variable? something this: case $option in $i) image=${options[$(($i-1))]%.tar} any pointer appreciated. you can match against multiple patterns in single clause: case $option in 1|2|3: echo "$option one, 2 or three" ;; esac if still typing you, can use simple pattern matching: case $option in # following matches # - single-digit numbers 0-9 # - two-digit numbers starting either 1 or 2 # - number 30 [0-9]|[12][0-9]|30) image=${options[$(($option-1))]%.tar} ;; *) echo "invalid option" 1>&2 exit 1 esac
Read more

apache - How do I stop my index.php being run twice for every user -

we've got webapp initial html served using apache , php. i noticed index.php being run twice every request. seems caused / effected rewrite rules in our .htaccess - rewritecond %{http_host} ^(www\.|hotels\.)ourdomain\.com$ [nc,or] rewritecond %{server_name} ^(www\.|hotels\.)ourdomain\.com$ [nc] rewriterule (.*) http://ourdomain.com/$1 [r=301] rewriterule ^hotels/([^/]+)/?\??(.*)$ ?d=$1&$2 [qsa] the final rule moving parameter url path query string. i.e. http://ourdomain.com/hotels/vegas?someparam=1 becomes http://ourdomain.com?d=vegas&someparam=1 if go directly query string version index.php run once. if use url redirected, index.php run twice (i'm checking adding error_log('end of index.php') file). so example going http://ourdomain.com/hotels/paris hits file twice http://ourdomain.com?d=paris hits once. i've seen this question , had @ blog mentioned , , can't find empty string url's (i've tried using yslow process). ...
Read more