javascript - Node.js Passport Login Race Condition -


i believe dealing race condition on node.js authentication using passportjs (specifically passport-local).

here router registration:

router.post('/', upload.single('avatar'), function(req, res, next) {     var usertype = req.body.usertype;     var username = req.body.username;     var password = req.body.password;     var email = req.body.email;     // convert buffer data base64 encoded string     var base64avatar = new buffer(req.file.buffer).tostring('base64');     var avatar = 'data:' + req.file.mimetype + ';base64,' + base64avatar;      var createduser;     if (usertype == 'viewer') {         createduser = new user.user(username, password, email, [], [], avatar).getinstance();     } else if (usertype == 'contributor') {         createduser = new contributor.contributor(username, password, email, [], [], avatar, []).getinstance();     }      req.login(createduser, function(err) {         if (err) { return next(err); }         req.session.save(function() {            res.redirect('/user/' + req.user.username);         });     }); });

in constructor of user model using typescript:

constructor(private _username: string, private _password: string, private\  _email: string, private _favorites: array<any>, private _inbox: array<any>, \ private _avatar: string) {         this._modelinstance = new usermodel({username: _username, password: _\ password, email: _email, favorites: _favorites, inbox: _inbox, avatar: _avata\ r});         this._modelinstance.save(); };

i've tried applying async.series to:

a) the model instance creation , save in user class constructor.

b) the createduser creation in route , req.login request.

i've tried (as can see) save session manually , use redirect callback ensure session saved. i've looked buffer , seems synchronous don't believe issue.

if call user model short string such myavatar login user in properly. when avatar string gets large. in case, user can login after automatic login not performed through req.login.

it telling user profile gets redirected isn't shown right after login, signalling trying login before model being saved (the profile page makes database query , isn't finding yet). refresh after redirect shows data on profile page, however.

am overlooking asynchronous issue somewhere?

i fixed moving save() logic registration router.

then add req.login call save() callback:

createduser.save(function(err, data) {     if (err) {             console.log(err);     } else {         req.login(createduser, function(err) {             if (err) { return next(err); }             req.session.save(function() {                 res.redirect('/user/' + req.user.username);             });         });     }  });

Comments

Post a Comment

Popular posts from this blog

java - pagination of xlsx file to XSSFworkbook using apache POI -

right in code, reading xlsx file, xssfworkbook, , writing database. but, when size of xlsx file increases, causes outofmemory error. can not increase server size, or divide xlsx file pieces. tried loading workbook using file (instead of inputstream), didn't either. i looking way read 10k rows @ time (instead of entire file @ once) , iteratively write workbook , database. is there way apache poi? poi contains called "eventmodel" designed purpose. it's mentioned in faq : the ss eventmodel package api reading excel files without loading whole spreadsheet memory. require more knowledge on part of user, reduces memory consumption more tenfold. based on awt event model in combination sax. if need read-only access, best way it. however, may want double check first if issue somewhere else. check out this item : i think poi using memory! can do? 1 comes quite lot, reason isn't might think. so, first thing check - what's source of prob...
Read more

Unlimited choices in BASH case statement -

consider simple bash snippet: case $option in 1) image=${options[0]%.tar} ;; 2) image=${options[1]%.tar} ;; 3) image=${options[2]%.tar} ;; 4) image=${options[3]%.tar} ;; *) echo "invalid option" exit 1 esac in real script numbers goes 30. makes pretty long. can somehow specify cases variable? something this: case $option in $i) image=${options[$(($i-1))]%.tar} any pointer appreciated. you can match against multiple patterns in single clause: case $option in 1|2|3: echo "$option one, 2 or three" ;; esac if still typing you, can use simple pattern matching: case $option in # following matches # - single-digit numbers 0-9 # - two-digit numbers starting either 1 or 2 # - number 30 [0-9]|[12][0-9]|30) image=${options[$(($option-1))]%.tar} ;; *) echo "invalid option" 1>&2 exit 1 esac
Read more

apache - How do I stop my index.php being run twice for every user -

we've got webapp initial html served using apache , php. i noticed index.php being run twice every request. seems caused / effected rewrite rules in our .htaccess - rewritecond %{http_host} ^(www\.|hotels\.)ourdomain\.com$ [nc,or] rewritecond %{server_name} ^(www\.|hotels\.)ourdomain\.com$ [nc] rewriterule (.*) http://ourdomain.com/$1 [r=301] rewriterule ^hotels/([^/]+)/?\??(.*)$ ?d=$1&$2 [qsa] the final rule moving parameter url path query string. i.e. http://ourdomain.com/hotels/vegas?someparam=1 becomes http://ourdomain.com?d=vegas&someparam=1 if go directly query string version index.php run once. if use url redirected, index.php run twice (i'm checking adding error_log('end of index.php') file). so example going http://ourdomain.com/hotels/paris hits file twice http://ourdomain.com?d=paris hits once. i've seen this question , had @ blog mentioned , , can't find empty string url's (i've tried using yslow process). ...
Read more