java - Thread safe struts web app with spring -


in struts 2 , spring web based application, please consider below sample.

the bookmanager has action returns map of books client. map service layer injected spring

public class bookmanager extends actionsupport {     //with setter , getter    private map<string, bookvo> books;     @inject    bookservice bookservice     @action("book-form")    public string form(){            setbooks(bookservice.getallbooks());    }  }

the service layer gets book list db returns map. 

@named public class bookservice(){     private map<string,bookvo> books;     public map<string,bookvo> getallbooks(){        books = new hashmap<string,bookvo>();        //fill books db        return books;   }  }

i have tested , found above implementation not thread safe.

  1. i can make code thread safe removing private field books bookservice , use method hashmap<string,bookvo>() books = new hashmap<string,bookvo>();. why change make code thread safe ?
  2. the struts action thread safe, shouldn't assure non thread safe spring service runs in thread safe manner.
  3. if use non thread safe version of service in action, making new service object instead of using spring inject, face no issue. why? if service not thread safe why making new instance , calling thread safe!

i can make code thread safe removing private field books bookservice , use method hashmap() books = new hashmap();. why change make code thread safe ?

because method-level variables thread safe, while class-level variables not.

the struts action thread safe, shouldn't assure non thread safe spring service runs in thread safe manner ?

nope. depends.

if use non thread safe version of service in action, making new service object instead of using spring inject, face no issue. why? if service not thread safe why making new instance , calling thread safe!

if instantiate manually in action, creating instance of object private action, thread-safe since actions threadlocal, , managed (that's means if bookservice class has @inject in it, container won't resolve them).

if instead have di managed container, instance not thread-safe; you're using (@inject, @named) more "spring", it's java ee, implementaton of jsr-330 (dependency injection) available in cdi-enabled applications (jsr-299).
cdi beans not thread safe. should use ejb3's @singleton thread-safe, don't need retain attribute @ class-level, since it's used returned, left there overwritten next time.

btw consider using reference cdi (weld in jboss) struts2 cdi-plugin, it's worthy of try.


Comments

Post a Comment

Popular posts from this blog

javascript - jQuery: Add class depending on URL in the best way -

i have html progress meter: <div class="col-md-3" style="margin-left: -20px;"> <div class="progress-pos active" id="progess-1"> <div class="progress-pos-inner"> login </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-2"> <div class="progress-pos-inner"> scan items </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-3"> <div class="progress-pos-inner"> confirm address </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-4"> <div class="progress-pos-in...
Read more

caching - How to check if a url path exists in the service worker cache -

i need check if particular url path exists in service worker cache. example, suppose url is: /myserviceworker/service?a=110&b=70 this url exists in cache, there many of them different values of , b. now, suppose want refresh of these urls, how can that? i want know how access key values service worker cache. if know key, plan follows: var url = new url(key); if(url.pathname === "\/myserviceworker/service") refetch key but not sure how cache key , in format is. mean, string or url? cache api has match() method returns promise resolving in response object if match or undefined if no match exists. second parameter object can specify ignoresearch not take account url parameters. the ignoresearch option supported firefox ( chrome status here ). in other hand, retrieve cache entries, can use keys() method.
Read more

Redirect to a HTTPS version using .htaccess -

i need modify .htaccess file redirect urls https version without "www". http://example.com --> https://example.com http://www.example.com --> https://example.com https://www.example.com --> https://example.com this how .htaccess file looks like: rewriteengine on rewritecond %{request_filename} !-d rewritecond %{request_filename} !-f rewriterule ^(.*)$ redirect.php?id=$1&page=$2 [qsa,l] what modifications need make .htaccess in order forward https without "www"? it depends on doing current code. looks file called redirect trying display php page seo friendly url. think might confusing people. anyway, need , force https without www, need 1 more rule above. also second rule needs two capture groups in rewriterule test string because wanting 2 different values using $1 , $2 references. rewriteengine on #rediect www non www and/or http https --- combinations. rewritecond %{http_host} !^example\.com [nc,or] rewritecond %{https} !^...
Read more