excel - Vba. 300mb+ optimizing macro -


(there more code after/before code below, part want optimize loops)

sheets("leanreport").activate  dim lrow long  on error resume next  lrow = application.worksheetfunction.match("05 2016", range("ab:ab"), 0)  on error goto 0  if lrow > 0     'code  end if  = 2 lastrowleanreport     r1 = cstr(cells(i, 5))     rg1 = cstr(cells(i, 24))      matrizrg1(i - 2) = rg1     matrizr1(i - 2) = r1 next  sheets("carrier").activate  = 2 lastrowcarrier     rg2 = cstr(cells(i, 1))     matrizrg2(i - 2) = rg2 next  j = 2 lastrowcarrier     p = lrow lastrowleanreport         if matrizrg2(j) = matrizrg1(p)             matrizrg3(j) = cells(j, 1)             matrizc1(j) = matrizr1(p)         end if     next p     if matrizrg3(j) = ""         x = 0 lrow             if matrizrg2(j) = matrizrg1(x)                 matrizrg3(j) = cells(j, 1)                 matrizc1(j) = matrizr1(p)             end if         next x     end if next j

is there way optimize macro? lastrowleanreport has more 700000 rows how can change loops else?

it gives me time error 6 & 7 out of memory.

in stead of loading data matrices , operate on matrices, operate directly on cells. don't consume memory large matrices.

to achieve this, first changed code can find equivalent expressions. example, assign matrix element , later use element. usage equivalent expression got data sheet , placed matrix element.

once done, can replace matrix references in last loop cell references. here see funny: source worksheet has apparently 2 header rows skip. later in loop skip them again, skip first 2 matrix elements! don't think mean:

for j = 0 lastrowcarrier - 2     p = lrow lastrowleanreport         if matrizrg2(j + 2) = matrizrg1(p)             matrizrg3(j + 2) = cells(j + 2, 1)             matrizc1(j + 2) = matrizr1(p)         end if     next p     if matrizrg3(j + 2) = ""         x = 0 lrow             if matrizrg2(j + 2) = matrizrg1(x)                 matrizrg3(j + 2) = cells(j + 2, 1)                 matrizc1(j + 2) = matrizr1(p)             end if         next x     end if next j

in above, think expression j + 2 should j (except in cells expression). continue on premises. note p in matrizr1(p) ill-defined points beyond matrix (i leave error fix).

next introduced variables worksheets, easier address them. changed loops start 0 row count - 2. gives following equivalent subroutine:

dim sheetcarrier worksheet dim sheetreport worksheet dim lrow long  set sheetreport = sheets("leanreport") sheetreport.activate lrow = application.worksheetfunction.match("05 2016", range("ab:ab"), 0)  = 0 lastrowleanreport - 2     matrizrg1(i) = cstr(sheetreport.cells(i + 2, 24))     matrizr1(i) = cstr(sheetreport.cells(i + 2, 5)) next  set sheetcarrier = sheets("carrier")  = 0 lastrowcarrier - 2     matrizrg2(i) = cstr(sheetcarrier.cells(i + 2, 1)) next  = 0 lastrowcarrier - 2     p = lrow lastrowleanreport         if matrizrg2(i) = matrizrg1(p)             matrizrg3(i) = sheetcarrier.cells(i + 2, 1)             matrizc1(i) = matrizr1(p)         end if     next p     if matrizrg3(i) = ""         x = 0 lrow             if matrizrg2(i) = matrizrg1(x)                 matrizrg3(i) = sheetcarrier.cells(i + 2, 1)                 matrizc1(i) = matrizr1(p)             end if         next x     end if next

in next step, have replace matrix references in last loop cell references earlier loops. these equivalences are:

matrizrg1(i) = cstr(sheetreport.cells(i + 2, 24)) matrizr1(i) = cstr(sheetreport.cells(i + 2, 5)) matrizrg2(i) = cstr(sheetcarrier.cells(i + 2, 1))

(i don't know output in matrizrg3 , matrizc1 going, leave in code - nice exercise you.)

the equivalent subroutine without matrices becomes:

dim sheetcarrier worksheet dim sheetreport worksheet dim lrow long  set sheetcarrier = sheets("carrier") set sheetreport = sheets("leanreport") sheetreport.activate lrow = application.worksheetfunction.match("05 2016", range("ab:ab"), 0)  = 0 lastrowcarrier - 2     p = lrow lastrowleanreport         if cstr(sheetcarrier.cells(i + 2, 1)) = cstr(sheetreport.cells(p + 2, 5))             matrizrg3(i) = sheetcarrier.cells(i + 2, 1)             matrizc1(i) = cstr(sheetreport.cells(p + 2, 5))         end if     next p     if matrizrg3(i) = ""         x = 0 lrow             if cstr(sheetcarrier.cells(i + 2, 1)) = cstr(sheetreport.cells(x + 2, 24))                 matrizrg3(i) = sheetcarrier.cells(i + 2, 1)                 matrizc1(i) = cstr(sheetreport.cells(p + 2, 5))   ' note: 'p' undefined!!             end if         next x     end if next

if works (and check it; errors made), can go on see if can optimize bit more.


Comments

Post a Comment

Popular posts from this blog

javascript - jQuery: Add class depending on URL in the best way -

i have html progress meter: <div class="col-md-3" style="margin-left: -20px;"> <div class="progress-pos active" id="progess-1"> <div class="progress-pos-inner"> login </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-2"> <div class="progress-pos-inner"> scan items </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-3"> <div class="progress-pos-inner"> confirm address </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-4"> <div class="progress-pos-in...
Read more

caching - How to check if a url path exists in the service worker cache -

i need check if particular url path exists in service worker cache. example, suppose url is: /myserviceworker/service?a=110&b=70 this url exists in cache, there many of them different values of , b. now, suppose want refresh of these urls, how can that? i want know how access key values service worker cache. if know key, plan follows: var url = new url(key); if(url.pathname === "\/myserviceworker/service") refetch key but not sure how cache key , in format is. mean, string or url? cache api has match() method returns promise resolving in response object if match or undefined if no match exists. second parameter object can specify ignoresearch not take account url parameters. the ignoresearch option supported firefox ( chrome status here ). in other hand, retrieve cache entries, can use keys() method.
Read more

Redirect to a HTTPS version using .htaccess -

i need modify .htaccess file redirect urls https version without "www". http://example.com --> https://example.com http://www.example.com --> https://example.com https://www.example.com --> https://example.com this how .htaccess file looks like: rewriteengine on rewritecond %{request_filename} !-d rewritecond %{request_filename} !-f rewriterule ^(.*)$ redirect.php?id=$1&page=$2 [qsa,l] what modifications need make .htaccess in order forward https without "www"? it depends on doing current code. looks file called redirect trying display php page seo friendly url. think might confusing people. anyway, need , force https without www, need 1 more rule above. also second rule needs two capture groups in rewriterule test string because wanting 2 different values using $1 , $2 references. rewriteengine on #rediect www non www and/or http https --- combinations. rewritecond %{http_host} !^example\.com [nc,or] rewritecond %{https} !^...
Read more