java - Memory leak in JNI function Java_java_io_WinNTFileSystem_rename0? -


i think following function in file jdk/src/windows/native/java/io/winntfilesystem_md.c in http://download.java.net/openjdk/jdk6/promoted/b27/openjdk-6-src-b27-26_oct_2012.tar.gz neglects free memory used frompath or topath if 1 of them found null...

jniexport jboolean jnicall java_java_io_winntfilesystem_rename0(jnienv *env, jobject this, jobject from,                                  jobject to) {      jboolean rv = jni_false;     wchar *frompath = filetontpath(env, from, ids.path);     wchar *topath = filetontpath(env, to, ids.path);     if (frompath == null || topath == null)         return jni_false;     if (_wrename(frompath, topath) == 0) {         rv = jni_true;     }     free(frompath);     free(topath);     return rv; }

am missing something? in fact bug?

resolved:  looking further details of function pathtontpath in io_util_md.c, can see filetontpath return null in case of out-of-memory error, guess don't care if neglect free malloced when jvm crash! still should documented in java_java_io_winntfilesystem_rename0 function in opinion though.

i think original point valid. while research other function used code suggest problem might not important, code lacking when viewed in , of itself.

the general rule of code reviews if has question, should answered in code @ least comment.

the general rule of comments if can expressed in code, possibly should be.

all of these issues go away if code written eliminate question.


Comments

Post a Comment

Popular posts from this blog

Redirect to a HTTPS version using .htaccess -

i need modify .htaccess file redirect urls https version without "www". http://example.com --> https://example.com http://www.example.com --> https://example.com https://www.example.com --> https://example.com this how .htaccess file looks like: rewriteengine on rewritecond %{request_filename} !-d rewritecond %{request_filename} !-f rewriterule ^(.*)$ redirect.php?id=$1&page=$2 [qsa,l] what modifications need make .htaccess in order forward https without "www"? it depends on doing current code. looks file called redirect trying display php page seo friendly url. think might confusing people. anyway, need , force https without www, need 1 more rule above. also second rule needs two capture groups in rewriterule test string because wanting 2 different values using $1 , $2 references. rewriteengine on #rediect www non www and/or http https --- combinations. rewritecond %{http_host} !^example\.com [nc,or] rewritecond %{https} !^...
Read more

Unlimited choices in BASH case statement -

consider simple bash snippet: case $option in 1) image=${options[0]%.tar} ;; 2) image=${options[1]%.tar} ;; 3) image=${options[2]%.tar} ;; 4) image=${options[3]%.tar} ;; *) echo "invalid option" exit 1 esac in real script numbers goes 30. makes pretty long. can somehow specify cases variable? something this: case $option in $i) image=${options[$(($i-1))]%.tar} any pointer appreciated. you can match against multiple patterns in single clause: case $option in 1|2|3: echo "$option one, 2 or three" ;; esac if still typing you, can use simple pattern matching: case $option in # following matches # - single-digit numbers 0-9 # - two-digit numbers starting either 1 or 2 # - number 30 [0-9]|[12][0-9]|30) image=${options[$(($option-1))]%.tar} ;; *) echo "invalid option" 1>&2 exit 1 esac
Read more

javascript - jQuery: Add class depending on URL in the best way -

i have html progress meter: <div class="col-md-3" style="margin-left: -20px;"> <div class="progress-pos active" id="progess-1"> <div class="progress-pos-inner"> login </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-2"> <div class="progress-pos-inner"> scan items </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-3"> <div class="progress-pos-inner"> confirm address </div> </div> </div> <div class="col-md-3 progress-pos-container"> <div class="progress-pos" id="progess-4"> <div class="progress-pos-in...
Read more